Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to render Template inside notebook #666

Merged
merged 8 commits into from
Oct 30, 2019
Merged

Add ability to render Template inside notebook #666

merged 8 commits into from
Oct 30, 2019

Conversation

philippjfr
Copy link
Member

This makes it possible to render custom Templates inside the notebook to see what they look like and to achieve more complex layouts.

@philippjfr philippjfr mentioned this pull request Sep 27, 2019
Merged
mattpap
mattpap reviewed Sep 30, 2019
View reviewed changes
panel/io/notebook.py Outdated Show resolved Hide resolved
@jsignell
Copy link
Member

jsignell commented Oct 29, 2019 •
edited
Loading

I think you'll need a change in setup.py and also possibly the MANIFEST.in to include the template file.

@philippjfr philippjfr force-pushed the philippjfr/nb_template_render branch from a85c530 to 48cf0f3 Compare October 29, 2019 17:38
@jsignell
Copy link
Member

jsignell commented Oct 30, 2019 •
edited
Loading

Seems like the panel dependency in holoviews is causing an issue on appveyor. Nevermind appveyor is just timing out after an hour. It really shouldn't take that long though...

@philippjfr
Copy link
Member Author

Seems like the panel dependency in holoviews is causing an issue on appveyor.

Fixing appveyor builds in a separate PR.

@philippjfr philippjfr merged commit c63a5ca into master Oct 30, 2019
@philippjfr philippjfr deleted the philippjfr/nb_template_render branch December 17, 2019 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattpap mattpap mattpap left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philippjfr @jsignell @mattpap